Update rust-lightning to use default_value_vec#850
Draft
carlaKC wants to merge 2 commits intolightningdevkit:mainfrom
Draft
Update rust-lightning to use default_value_vec#850carlaKC wants to merge 2 commits intolightningdevkit:mainfrom
carlaKC wants to merge 2 commits intolightningdevkit:mainfrom
Conversation
Update to be able to write vectors of HTLCLocator for PaymentForwarded. Note that we still don't expect to receive multiple outgoing HTLCs because trampoline has not yet been enabled, but we lay the groundwork here.
|
👋 Hi! I see this is a draft PR. |
carlaKC
commented
Mar 26, 2026
| // not support JIT channels in combination with trampoline. We're not at risk of | ||
| // double-reporting a skimmed fee when we have multiple next_htlcs because we | ||
| // expect our skimmed fee to be zero. | ||
| if skimmed_fee_msat.is_some() { |
Contributor
Author
There was a problem hiding this comment.
This seems good enough for now, but will consider further changes to PaymentForwarded in LDK to possibly make this mapping a bit cleaner.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #4507